-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ New probes: code-review #3302
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3302 +/- ##
==========================================
- Coverage 75.48% 68.81% -6.67%
==========================================
Files 230 232 +2
Lines 15621 15763 +142
==========================================
- Hits 11792 10848 -944
- Misses 3103 4249 +1146
+ Partials 726 666 -60 |
Bumps [github.com/goreleaser/goreleaser](https://github.com/goreleaser/goreleaser) from 1.18.2 to 1.19.1. - [Release notes](https://github.com/goreleaser/goreleaser/releases) - [Changelog](https://github.com/goreleaser/goreleaser/blob/main/.goreleaser.yaml) - [Commits](goreleaser/goreleaser@v1.18.2...v1.19.1) --- updated-dependencies: - dependency-name: github.com/goreleaser/goreleaser dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
…least found unique reviewers Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
…ogins Signed-off-by: André Backman <andre.backman@nokia.com>
…ogins Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
c65c111
to
4be18d6
Compare
@raghavkaul : i missed one //nolint:goimports . This time it should work. please review |
4be18d6
to
b89635f
Compare
@raghavkaul : please review i have removed the linters from probes/entries.go |
b89635f
to
5cd7bd2
Compare
@raghavkaul : Thanks for reviewing all previous code changes, Now added some testcase to increase the coverage please review |
Signed-off-by: jitsengupta17 <145664639+jitsengupta17@users.noreply.github.com>
5cd7bd2
to
4c486eb
Compare
@raghavkaul : Thanks for reviewing my previous code ,the error are now removed please review this changes |
@jitsengupta17 Would you like to give me write access to your repository/branch so I can help get this ready to merge? |
@raghavkaul: access right has been provided to you. please help us to merge the code. Thanks |
@raghavkaul I've sent an invite for you. After you accept the invitation you will be able to push to nokia:probes/code-review. Thanks. |
@raghavkaul : Thank you so much for helping us to merge the code. |
What kind of change does this PR introduce?
Adds three probes that extends the Code-review check. The probes:
codeApproved
checks if each changeset has been approved at least once
codeReviewed
checks if each changeset has been reviewed at least once
codeReviewedTwoReviewers
checks if each changeset has been reviewed by two unique reviewers
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Fixes #3265
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)